GH-75586: Fix case where PATHEXT isn't applied to items in PATH (Windows) by csm10495 · Pull Request #103179 · python/cpython

csm10495 · 2023-04-02T02:10:46Z

GH-75586 - Fix case where PATHEXT isn't applied to items in PATH.

The logic change here makes it so that if the command passed into shutil.which on windows, it will be verified against how it is passed in and against the various items in PATHEXT.

For example:

shutil.which('C:/windows/system32/cmd')

will now return

'C:/windows/system32/cmd.EXE'

Instead of None.

If this looks good, I'd be happy to create a changelog entry, etc. Just feeling the water with this first commit.

…H (Windows)

Lib/shutil.py

csm10495 · 2023-04-02T22:00:05Z

@eryksun I think i fixed everything. Check again. Thanks!

Lib/shutil.py

Co-authored-by: Eryk Sun <[email protected]>

Lib/shutil.py

Lib/test/test_shutil.py

Co-authored-by: Eryk Sun <[email protected]>

Lib/shutil.py

Co-authored-by: Steve Dower <[email protected]>

csm10495 · 2023-04-04T20:26:56Z

@zooba updated and added a corresponding test.

zooba · 2023-04-04T20:32:06Z

Looks good, and the tests all patch the call to that API so we shouldn't be impacted if the test machine has it configured differently.

Once CI passes, and unless someone else speaks up, I'll merge. Thanks for all your work on this!

csm10495 · 2023-04-04T20:39:38Z

Got a doctest failure... The error is odd.. maybe its transient? I'll push an empty commit to see if it helps.

Testing of doctests in the sources finished, look at the results in build/doctest/output.txt.
python: ./Include/internal/pycore_typeobject.h:75: _PyType_GetModuleState: Assertion `et->ht_module' failed.
Aborted (core dumped)
make[1]: *** [Makefile:49: build] Error 134
make[1]: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Testing of doctests in the sources finished, look at the results in build/doctest/output.txt
make: *** [Makefile:127: doctest] Error 1
make: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Error: Process completed with exit code 2.

Doc/library/shutil.rst

csm10495 · 2023-04-04T20:50:59Z

@eryksun added. Thanks.

eryksun

LGTM. Thank you, Charles.

…he OS (pythonGH-103179)

vstinner · 2024-11-19T10:55:51Z

This change introduced a regression: #127001.

pythonGH-75586 - Fix case where PATHEXT isn't applied to items in PAT…

01c152e

…H (Windows)

bedevere-bot added the awaiting review label Apr 2, 2023

bedevere-bot mentioned this pull request Apr 2, 2023

shutil.which doesn't find files without PATHEXT extension on Windows #75586

Closed

arhadthedev added OS-windows stdlib Standard Library Python modules in the Lib/ directory labels Apr 2, 2023

arhadthedev changed the title ~~GH-75586 - Fix case where PATHEXT isn't applied to items in PATH (Win…~~ GH-75586: Fix case where PATHEXT isn't applied to items in PATH (Windows) Apr 2, 2023

arhadthedev requested a review from a team April 2, 2023 03:58

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

csm10495 added 2 commits April 2, 2023 13:06

PR updates

0d4cd7b

Add tests

5fac84a

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

PR updates

fa145da

csm10495 and others added 4 commits April 2, 2023 15:00

line len fix

84a7976

📜🤖 Added by blurb_it.

63a06c4

Add changelog entry

7686a23

Double backticks

381e4fe

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

csm10495 and others added 2 commits April 2, 2023 15:36

Update Lib/shutil.py

e7c0b58

Co-authored-by: Eryk Sun <[email protected]>

PR updates

26e3b15

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

pep8 fix

6272b62

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/test/test_shutil.py Outdated Show resolved Hide resolved

eryksun reviewed Apr 2, 2023

View reviewed changes

Lib/test/test_shutil.py Outdated Show resolved Hide resolved

csm10495 and others added 2 commits April 2, 2023 16:10

Update Lib/test/test_shutil.py

b6d29c8

Co-authored-by: Eryk Sun <[email protected]>

Update Lib/test/test_shutil.py

1096cb7

Co-authored-by: Eryk Sun <[email protected]>

eryksun added the 3.12 only security fixes label Apr 2, 2023

eryksun reviewed Apr 4, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

zooba reviewed Apr 4, 2023

View reviewed changes

Lib/shutil.py Outdated Show resolved Hide resolved

csm10495 and others added 2 commits April 4, 2023 13:16

Update Lib/shutil.py

499d2de

Co-authored-by: Steve Dower <[email protected]>

Add test for behavior

3ead780

csm10495 requested a review from zooba April 4, 2023 20:27

kick ci

f9267da

eryksun reviewed Apr 4, 2023

View reviewed changes

Doc/library/shutil.rst Outdated Show resolved Hide resolved

csm10495 added 2 commits April 4, 2023 13:49

Mention cwd first behavior

d1e68ff

Wording

9badf8c

eryksun approved these changes Apr 4, 2023

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Apr 4, 2023

zooba merged commit 935aa45 into python:main Apr 4, 2023

bedevere-bot removed the awaiting core review label Apr 4, 2023

eryksun mentioned this pull request Apr 8, 2023

shutil.which wrong result on Windows #68693

Closed

gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023

pythonGH-75586: Make shutil.which() on Windows more consistent with t…

eaaa7b9

…he OS (pythonGH-103179)

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023

pythonGH-75586: Make shutil.which() on Windows more consistent with t…

60d711f

…he OS (pythonGH-103179)

dairiki mentioned this pull request Sep 20, 2023

On Windows, shutil.which incorrectly resolves to non-executable extensionless files (python >= 3.12.0b1) #109590

Closed

lazka mentioned this pull request Sep 29, 2023

Missing rule for glib-mkenums mesonbuild/meson#12271

Closed

weiji14 mentioned this pull request Oct 25, 2023

Add support for Python 3.12 GenericMappingTools/pygmt#2711

Merged

7 tasks

popescu-v mentioned this pull request Oct 8, 2024

245 support the new version of khiops env KhiopsML/khiops-python#252

Merged

This was referenced Nov 19, 2024

external_project: workaround for MinGW mesonbuild/meson#13886

Merged

shutil.which() can return non-executable path starting with 3.12 on Windows #127001

Closed

Avasam mentioned this pull request Mar 4, 2025

shutil.which cannot return PathLike, and fails with cmd: PathLike on Windows Python < 3.12 python/typeshed#13580

Merged

liaochris mentioned this pull request Jan 7, 2026

PR for #137: test new python versions JMSLab/Template#138

Merged

Uh oh!

Conversation

csm10495 commented Apr 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csm10495 commented Apr 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csm10495 commented Apr 4, 2023

Uh oh!

zooba commented Apr 4, 2023

Uh oh!

csm10495 commented Apr 4, 2023

Uh oh!

Uh oh!

csm10495 commented Apr 4, 2023

Uh oh!

eryksun left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants